-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docker support + 1 command installation using docker-compose #8578
Conversation
please approve the workflow |
Ready to merge |
the build is not performed inside a container but is left to the user. Shouldn't it be better to ensure binary compatibility? |
No, the build is performed inside the container, the user has only to modify the Makefile and the container will build yolo inside the container so binary compatibility is ensured.
it will allow the user to setup yolo on windows using containers instead of MSbuilds and this docker build |
@cenit we also took advantage of multi stage so that the output container has minimal size and best performance which was not used in #4148 cpu container has size of 170 mega bytes |
please merge |
merging a PR might take some time and is not guaranteed in any case :) |
great |
Please approve the workflow and tell me if you lke to have a demo of the setup and running |
@AlexeyAB
@cenit
@WongKinYiu
Added docker support for yolo using 2 docker files one for building using the gpu and the other for the cpu.
Also added 1 command installation utility using docker-compose:
so the installation steps are :
docker-compose run yolo-cpu bash
docker-compose run yolo-gpu bash
After that you will find your self in a bash terminal on a linux container logged in with username yolo and password yolo.
Now you can run any command you need from the yolo documentation.
The docker-compose file will allow you to modify the enviroment as you want whether you want to bind directories, expose ports, connect multiple gpus and much more.
That commit will successfully complete the mile stone of having easy installation of the Darknet.
fixes #6960 , fixes #8140 , fixes #3121 , fixes #7644